Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI more robust #62

Merged
merged 1 commit into from
May 31, 2024
Merged

Make CI more robust #62

merged 1 commit into from
May 31, 2024

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented May 31, 2024

Failure now in master merge PR check, because runner did not have shellcheck. Install it.
Also, prior to installation - do sudo apt-get update, otherwise the installations can fail randomly.

Todos

Not applicable (NA), this is CI-only improvement.

  • Changelog updated
  • Run shellcheck or pysh-check before committing code - no more warnings than earlier (preferably less)
  • Will tag a proper release, if need be.
  • Will update required recipes/builds as well.
  • Will update also the versions to relevant places:
    • edge-info/edge-info has the version number (around line 37)
    • identity-tools/VERSION has the version number as well.

Failure now in master merge, because runner did not have shellcheck.
Install it.
@JanneKiiskila JanneKiiskila self-assigned this May 31, 2024
@JanneKiiskila JanneKiiskila merged commit 8787591 into master May 31, 2024
7 checks passed
@JanneKiiskila JanneKiiskila deleted the make-ci-more-robust branch May 31, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant