Fix edge-testnet -h handling & update changelog #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in edge-testnet, it's now trying to call a function that does not' exist.
We are trying to call a function which does not exist in the script.
Bump version to 2.3.5.
This will fail however as of now. ``` pe-utils$ fw-tools/edge-testnet --domain pdm-sandbox.io [ FAILED ] ping bootstrappdm-sandbox.io [ FAILED ] ping tcp-bootstrappdm-sandbox.io [ FAILED ] ping lwm2mpdm-sandbox.io [ FAILED ] ping tcp-lwm2mpdm-sandbox.io [ FAILED ] netcat bootstrappdm-sandbox.io 5684 [ FAILED ] netcat tcp-bootstrappdm-sandbox.io 5684 [ FAILED ] netcat bootstrappdm-sandbox.io 443 [ FAILED ] netcat tcp-bootstrappdm-sandbox.io 443 [ FAILED ] netcat lwm2mpdm-sandbox.io 5684 [ FAILED ] netcat tcp-lwm2mpdm-sandbox.io 5684 [ FAILED ] netcat lwm2mpdm-sandbox.io 443 [ FAILED ] netcat tcp-lwm2mpdm-sandbox.io 443 [ FAILED ] netcat edge-k8spdm-sandbox.io 443 [ FAILED ] netcat gatewayspdm-sandbox.io 443 [ FAILED ] netcat containerspdm-sandbox.io 443 fw-tools/edge-testnet: line 126: !LOG_FILE_NAME: unbound variable ```
Or at least it should not fail now with undefined variable.
jenia81
reviewed
May 30, 2024
JanneKiiskila
changed the title
As per Jenia's review feedback.
JanneKiiskila
force-pushed
the
edge-testnet-h
branch
from
29387b8
to
c0cb4ea
Compare
JanneKiiskila
force-pushed
the
edge-testnet-h
branch
from
c0cb4ea
to
229b45f
Compare
jenia81
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip443and--skiptcpoptions.openssltests to break script in case of failure.Todos
shellcheckorpysh-checkbefore committing code - no more warnings than earlier (preferably less)