Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Avoid blocking when reading data from request stream #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🔧 Avoid blocking when reading data from request stream #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f2cd79
Avoid blocking when reading data from request stream
Aug 29, 2019
76ef009
Add news file for pull request #364
Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/news/29082019.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix webhook_grok example: avoid blocking when reading data from request stream
2 changes: 1 addition & 1 deletion examples/connect/webhook_ngrok.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def webhook_handler(request):

Passes the raw http body directly to mbed sdk, to notify that a webhook was received
"""
body = request.stream.read().decode('utf8')
body = request.stream.read(request.content_length or 0).decode('utf8')
print('webhook handler saw:', body)
api.notify_webhook_received(payload=body)

Expand Down