Skip to content

Commit

Permalink
removing convert method on Vector{<:Group}
Browse files Browse the repository at this point in the history
  • Loading branch information
Janis Erdmanis committed May 22, 2023
1 parent a900292 commit 61ef3a6
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/groups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@ import Base./

name(x::G) where G <: Group = name(G)

#Base.convert(::Type{Vector{G}}, x::Vector) where G <: Group = G[ G <| i for i in x]
#Base.convert(::Type{Vector{G}}, x::Vector) where G <: Group = G[convert(G, i) for i in x]
#Base.convert(::Type{Vector{G}}, x::Vector) where G <: Group = G[]


Base.rand(prg::PRG, ::Type{G}, N::Integer; nr::Integer = 0) where G <: Group = Vector{G} <| rand(prg, spec(G), N; nr)

Base.ones(x::Vector{G}) where G <: Group = [one(i) for i in x] # need to extend this
Expand Down

2 comments on commit 61ef3a6

@JanisErdmanis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/84047

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.3.4 -m "<description of version>" 61ef3a6c5f221903e887794fb40611b1718a382b
git push origin v0.3.4

Please sign in to comment.