Adding environment checks to pawsey lua for handling errors #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelahi
requested review from
dipietrantonio,
ddeeptimahanti and
marcodelapierre
marcodelapierre
requested changes
Sep 1, 2023
| for ind,var in ipairs(envvars) do | ||
| local env = os.getenv(var) | ||
| if env == nil or env == "" then | ||
| nid = os.getenv("HOSTNAME") |
There was a problem hiding this comment.
what happens if HOSTNAME itself is not set? -- as unlikely as HOME/USER I reckon.
maybe you could substitute with a Lua command that executes the hostname command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of tickets reporting an issue with the pawseyenv module. These are misleading errors because there isn't an issue with the module per say, rather that there are issues with some environment variables that are undefined. This PR is draft but with some feedback could be integrated into the deployment.