Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing ES6 support for latest version of gulp #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added missing ES6 support for latest version of gulp #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,17 @@ To run tests, type `npm test` or `karma start` in the terminal. Read more about
Tools needed to run this app:
* `node` and `npm`
Once you have these, install the following as globals:
`npm install -g gulp karma karma-cli webpack`
`npm install -g gulp gulp-cli karma karma-cli webpack`

## Installing
* `fork` this repo
* `clone` your fork
* `npm install -g gulp karma karma-cli webpack` install global cli dependencies
* `npm install -g gulp gulp-cli karma karma-cli webpack` install global cli dependencies
* `npm install` to install dependencies

## Running the App
NG6 uses Gulp to build and launch the development environment. After you have installed all dependencies, you may run the app. Running `gulp` will bundle the app with `webpack`, launch a development server, and watch all files. The port will be displayed in the terminal.

### Gulp Tasks
Here's a list of available tasks:
* `webpack`
Expand All @@ -113,7 +113,7 @@ Here's a list of available tasks:
* runs `serve`.
* `component`
* scaffolds a new Angular component. [Read below](#generating-components) for usage details.

### Testing
To run the tests, run `npm test` or `karma start`.

Expand Down Expand Up @@ -161,7 +161,7 @@ Because the argument to `--name` applies to the folder name **and** the actual c

___

enjoy — **AngularClass**
enjoy — **AngularClass**

<br><br>

Expand Down
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@
"type": "git",
"url": "https://github.com/angularclass/NG6-starter.git"
},
"babel": {
Copy link
Collaborator

@fesor fesor Jun 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have .babelrc, isn't it enough?

Maybe move content of .babelrc here and remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it should be enough to have it in .babelrc. Unfortunately, that didn't work for me. May be that is because I don't have babel installed globally.

Wouldn't be better if we have it at both places to ensure the build doesn't fail?

"presets": [
"es2015"
]
},
"author": "AngularClass",
"license": "Apache-2.0"
}