Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission to BioPAX/SBGN: Missing types #401

Closed
jvwong opened this issue Dec 11, 2018 · 5 comments
Closed

Submission to BioPAX/SBGN: Missing types #401

jvwong opened this issue Dec 11, 2018 · 5 comments
Assignees
Labels

Comments

@jvwong
Copy link
Member

jvwong commented Dec 11, 2018

Looks like no edge created for “protein activates protein” and “chemical activates protein” cases.

Here is a factoid document created from http://unstable.factoid.baderlab.org. After submitting it to PC we have this result in http://appsbeta.pathwaycommons.org.

See that the interaction between FSHB and IGF1 (protein activates protein) and the one between Estradiol and LEP (chemical activates protein) are missing in the resulting graph.

@IgorRodchenkov
Copy link
Member

IgorRodchenkov commented Dec 12, 2018

@jvwong @metincansiper @maxkfranz

The BioPAX looks just fine - as we designed and expected it. So, this must be either the paxtools/sbgn-converter (java) issue or sbgnml-to-cytoscape npm module issue.

I could create an issue and try to test and fix if it is in Paxtools.

FYI: http://web.newteditor.org/ and http://www.cs.bilkent.edu.tr/~ivis/SBGNViz.js both do much worse job than app-ui using the same input SBGN model.

@IgorRodchenkov
Copy link
Member

IgorRodchenkov commented Dec 13, 2018

I confirm that it's a Paxtools/sbgn-converter issue BioPAX/Paxtools#41
(After fixing Paxtools, the PC10 server(s) must be re-built and restarted in order this issue to be fixed as well).

IgorRodchenkov added a commit to PathwayCommons/factoid-converters that referenced this issue Dec 14, 2018
@IgorRodchenkov
Copy link
Member

IgorRodchenkov commented Dec 14, 2018

95% fixed :) try it.
I also noticed that in case of "BMP2 activates JUN via phosphorylation", you cannot see "inactive"/"active" states on the JUN, but can see "!phosphorylated" and "phosphorylated"...

@jvwong
Copy link
Member Author

jvwong commented Dec 14, 2018

I also noticed that in case of "BMP2 activates JUN via phosphorylation", you cannot see "inactive"/"active" states on the JUN, but can see "!phosphorylated" and "phosphorylated"...

Possibly related - PathwayCommons/sbgnml-to-cytoscape#22

@IgorRodchenkov
Copy link
Member

IgorRodchenkov commented Dec 14, 2018

Now it looks as follows:

in factod -
image

in the apps:
image

@IgorRodchenkov IgorRodchenkov self-assigned this Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants