Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBGN converter does not work for control-control and modulation cases #41

Closed
IgorRodchenkov opened this issue Dec 13, 2018 · 0 comments
Closed

SBGN converter does not work for control-control and modulation cases #41

IgorRodchenkov opened this issue Dec 13, 2018 · 0 comments
Assignees
@IgorRodchenkov

Comments

@IgorRodchenkov
Copy link
Member

IgorRodchenkov commented Dec 13, 2018 •
edited
Loading

SBGN converter does not work for control-control and modulation cases - it only generates two participants glyphs but no interactions, no edges.

Fixing this issue will help PathwayCommons/factoid#401.

(I will generated test data models and tests to fix shortly.)
@IgorRodchenkov IgorRodchenkov self-assigned this Dec 13, 2018
@IgorRodchenkov IgorRodchenkov mentioned this issue Dec 13, 2018
Closed
IgorRodchenkov added a commit that referenced this issue Dec 13, 2018
@IgorRodchenkov
Added test data and test stubs to address issue #41.
22a5956
IgorRodchenkov added a commit that referenced this issue Dec 14, 2018
@IgorRodchenkov
Refs #41 (control-control, modulation) and addresses other issues/bug…
3c02a7c 
…s: -

- latest NEWT/SBGNViz can finally visualize these data (GI, TR, base Interactions were not displayed ok);
- refactored the way the "control structures" are generated (put the recursion in the other place; not using NOT glyphs anymore)
- genetic interactions are now represented as 'AND' glyph (connecting the genes with logical arcs) and stimulation (arrow) arc - to the phenotype (e.g. 'lethal').
@IgorRodchenkov IgorRodchenkov mentioned this issue Dec 14, 2018
Merged
IgorRodchenkov added a commit that referenced this issue Dec 14, 2018
@IgorRodchenkov
Refs issue #41 and PR #42: incremented version (5.2.1-SNAPSHOT); comm…
62d25f3 
…ented out experimental code; fixed several warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgorRodchenkov IgorRodchenkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IgorRodchenkov