Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ren L-03: Ensure erc20 creator crowdfund token ops are valid #390

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Apr 7, 2024

No description provided.

Copy link

height bot commented Apr 7, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Apr 7, 2024

Gas Report:

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 66.31%. Comparing base (a1f7059) to head (b989ee7).

Files Patch % Lines
contracts/crowdfund/ERC20LaunchCrowdfund.sol 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   66.40%   66.31%   -0.09%     
==========================================
  Files          71       71              
  Lines        3000     3004       +4     
  Branches      654      654              
==========================================
  Hits         1992     1992              
- Misses        801      805       +4     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 requested a review from 0xble April 9, 2024 17:41
Copy link
Collaborator

@0xble 0xble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

contracts/utils/IERC20Creator.sol Outdated Show resolved Hide resolved
@arr00 arr00 enabled auto-merge (squash) April 11, 2024 14:21
@arr00 arr00 disabled auto-merge April 11, 2024 14:22
@arr00 arr00 enabled auto-merge (squash) April 11, 2024 14:23
@arr00 arr00 merged commit 15eca6e into main Apr 11, 2024
6 checks passed
@arr00 arr00 deleted the mitigation/restrict-erc20-creator branch April 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants