Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: update deploy constants and verify #387

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Mar 26, 2024

Motivation

Solution

@0xble 0xble requested a review from arr00 March 26, 2024 19:46
Copy link

height bot commented Mar 26, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Mar 26, 2024

Gas Report:
Accept Proposal: 31749
Create party custom metadata: 726170
Create party vanilla: 296856
Contribute to ETH party: 204946
Batch contribute two memberships to ETH party: 278336
Create proposal transfer eth: 141169
Execute proposal transfer eth: 123058
Create proposal distribute: 139523
Execute proposal distribute: 232549
Claim distribution: 74905

@0xble 0xble force-pushed the deploy/token-distributor-v3 branch from a663b41 to 9fe2087 Compare March 26, 2024 20:33
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tokenDistributorV3 changed to be incorrect?

@arr00
Copy link
Contributor

arr00 commented May 8, 2024

@0xble should this be closed?

@0xble
Copy link
Collaborator Author

0xble commented May 8, 2024

@0xble should this be closed?

There's an update to the verify.ts that's important, but I'll undo the change to addresses.

@0xble 0xble requested a review from arr00 May 8, 2024 16:05
@0xble 0xble merged commit 8522dba into main May 8, 2024
6 checks passed
@arr00 arr00 deleted the deploy/token-distributor-v3 branch May 9, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants