Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update distributor #384

Merged
merged 4 commits into from
Mar 26, 2024
Merged

update distributor #384

merged 4 commits into from
Mar 26, 2024

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Mar 22, 2024

Motivation

Solution

@0xble 0xble requested a review from arr00 March 22, 2024 22:35
Copy link

height bot commented Mar 22, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Gas Report:

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.75%. Comparing base (136ed9b) to head (9588253).

Files Patch % Lines
contracts/renderers/PartyNFTRenderer.sol 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   66.82%   66.75%   -0.07%     
==========================================
  Files          70       70              
  Lines        2963     2963              
  Branches      647      648       +1     
==========================================
- Hits         1980     1978       -2     
- Misses        783      785       +2     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than missing addresses

@arr00 arr00 merged commit 1512942 into main Mar 26, 2024
6 checks passed
@arr00 arr00 deleted the token-distributor-v3 branch March 26, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants