Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigations: Dynamic party card prices #371

Merged

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Jan 2, 2024

A quick note here. I switched the distributionsRequireVote bool into the distributionsConfig enum. Enums are stored as uint8 in storage (and bools are stored to take a whole byte when packed in storage in a struct). Therefore, the storage layout remains identical so the proposal execution engine will be backwards compatible. Enum values map to the previous boolean values.

Copy link

height bot commented Jan 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b2e4ec2) 66.09% compared to head (d6288ae) 66.56%.

Files Patch % Lines
contracts/party/PartyGovernance.sol 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat/dynamic-party-card-price     #371      +/-   ##
=================================================================
+ Coverage                          66.09%   66.56%   +0.47%     
=================================================================
  Files                                 69       69              
  Lines                               2911     2934      +23     
  Branches                             636      644       +8     
=================================================================
+ Hits                                1924     1953      +29     
+ Misses                               785      783       -2     
+ Partials                             202      198       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 changed the title initial mitigations mitigations: Dynamic party card prices Jan 2, 2024
@arr00 arr00 marked this pull request as ready for review January 3, 2024 22:26
@arr00 arr00 requested a review from 0xble January 3, 2024 22:26
Copy link
Collaborator

@0xble 0xble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that all issues brought up from audits were mitigated, except the issue of users potentially losing funds upon rageQuit() which is still being discussed. All mitigations that were included so far look good.

@arr00 arr00 merged commit 5c97c14 into feat/dynamic-party-card-price Jan 9, 2024
5 checks passed
@arr00 arr00 deleted the mitigations/dynamic-party-card-price branch January 9, 2024 15:41
arr00 added a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants