delete unused error and update tests

PartyDAO · Feb 16, 2024 · 8b67ebb · 8b67ebb
1 parent b2ca09c
commit 8b67ebb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/contracts/distribution/PushDistributor.sol b/contracts/distribution/PushDistributor.sol
@@ -13,7 +13,6 @@ contract PushDistributor {
     event Distributed(Party party, IERC20 token, address[] members, uint256 amount);
 
     error NotEnoughETH(uint256 expectedAmount, uint256 receivedAmount);
-    error UnexpectedETH(uint256 amount);
     error WrongProposalId(uint256 proposalId);
     error WrongMembers();
     error MembersNotSorted();

diff --git a/test/distribution/PushDistributor.t.sol b/test/distribution/PushDistributor.t.sol
@@ -298,7 +298,12 @@ contract PushDistributorTest is SetupPartyHelper {
 
             uint256 proposalId = _proposeAndPassProposal(proposal);
 
-            vm.expectRevert();
+            vm.expectRevert(
+                abi.encodeWithSelector(
+                    ArbitraryCallsProposal.ArbitraryCallFailedError.selector,
+                    abi.encodeWithSelector(PushDistributor.WrongProposalId.selector, 2)
+                )
+            );
             _executeProposal(proposalId, proposal);
         }
 
@@ -353,7 +358,12 @@ contract PushDistributorTest is SetupPartyHelper {
 
             uint256 proposalId = _proposeAndPassProposal(proposal);
 
-            vm.expectRevert();
+            vm.expectRevert(
+                abi.encodeWithSelector(
+                    ArbitraryCallsProposal.ArbitraryCallFailedError.selector,
+                    abi.encodePacked(PushDistributor.MembersNotSorted.selector)
+                )
+            );
             _executeProposal(proposalId, proposal);
         }
 
@@ -388,7 +398,12 @@ contract PushDistributorTest is SetupPartyHelper {
 
         uint256 proposalId = _proposeAndPassProposal(proposal);
 
-        vm.expectRevert();
+        vm.expectRevert(
+            abi.encodeWithSelector(
+                ArbitraryCallsProposal.ArbitraryCallFailedError.selector,
+                abi.encodePacked(PushDistributor.WrongMembers.selector)
+            )
+        );
         _executeProposal(proposalId, proposal);
 
         // Add the last member back and pass