Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigation: check onERC1155Received() #28

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Aug 9, 2024

No description provided.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (6d59aba) to head (3fb5f8d).
Report is 1 commits behind head on main.

Files Patch % Lines
src/MintERC1155.sol 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   92.20%   86.79%   -5.42%     
==========================================
  Files           2        2              
  Lines         154      159       +5     
  Branches       29       30       +1     
==========================================
- Hits          142      138       -4     
- Misses         12       21       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 marked this pull request as ready for review August 12, 2024 18:41
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure we have a test or two for this

@arr00 arr00 changed the base branch from main to mitigations August 12, 2024 18:43
@arr00 arr00 merged commit 9a7c940 into mitigations Aug 12, 2024
4 of 6 checks passed
@arr00 arr00 deleted the mitigation/check-onERC1155Received branch August 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants