Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigation: mintBatch() gas grief #27

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Aug 9, 2024

No description provided.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (0fc9646) to head (2435739).

Additional details and impacted files
@@               Coverage Diff               @@
##           mitigations      #27      +/-   ##
===============================================
+ Coverage        87.80%   87.87%   +0.07%     
===============================================
  Files                3        3              
  Lines              164      165       +1     
  Branches            29       30       +1     
===============================================
+ Hits               144      145       +1     
  Misses              20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use the discussed mitigation with the auditors

@arr00 arr00 changed the base branch from main to mitigations August 12, 2024 18:44
@0xble 0xble closed this Aug 12, 2024
@0xble 0xble reopened this Aug 12, 2024
@0xble 0xble requested a review from arr00 August 12, 2024 20:00
@0xble 0xble marked this pull request as ready for review August 12, 2024 20:01
@0xble 0xble force-pushed the mitigation/insufficient-gas-mint branch from 9204511 to 25537f0 Compare August 12, 2024 20:03
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a test or two

@0xble 0xble merged commit 85aa8a9 into mitigations Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants