Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ERC20 airdrop tool #27

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: ERC20 airdrop tool #27

wants to merge 10 commits into from

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented May 1, 2024 •
edited by arr00
Loading

Link T-4827

@0xble 0xble requested a review from arr00 May 1, 2024 13:11
@height Height
Copy link

height bot commented May 1, 2024 •
edited
Loading

This pull request has been linked to 3 tasks:

💡Tip: Add "Close T-4827" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

arr00
arr00 reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

src/ERC20Airdropper.sol Outdated Show resolved Hide resolved
arr00
arr00 reviewed May 2, 2024
View reviewed changes
src/ERC20Airdropper.sol Outdated Show resolved Hide resolved
arr00
arr00 suggested changes May 6, 2024
View reviewed changes
src/vendor/Dropper.sol Outdated Show resolved Hide resolved
@0xble 0xble force-pushed the feat/erc20-airdropper branch from eeee590 to d18c3ba Compare May 7, 2024 18:37
@0xble 0xble force-pushed the feat/erc20-airdropper branch from d18c3ba to 7b0569f Compare May 7, 2024 18:38
@0xble 0xble requested a review from arr00 May 8, 2024 17:06
@arr00
Copy link
Contributor

arr00 commented May 9, 2024

Link T-4848
Link T-4850

arr00
arr00 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial thoughts

src/ERC20Creator.sol Outdated Show resolved Hide resolved
src/GovernableERC20.sol Outdated Show resolved Hide resolved
@0xble 0xble requested a review from arr00 May 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arr00 arr00 Awaiting requested review from arr00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xble @arr00