Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required node and npm versions #3031

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Dec 16, 2024

Description

With this PR, we're updating our minimum node and npm versions from 18.12 to 22.12.0 and 8.19.2 to 10.9.0 respectively.

Motivation and context

Upgrade our minimum requirements to the latest LTS version.

How has this been tested?

Verified that things still build and that we aren't getting any errors from the upgrade.

Summary by CodeRabbit

  • New Features

    • Updated Node.js and npm version requirements for improved compatibility.
  • Chores

    • Updated the Node.js version in the .nvmrc file.

@acicovic acicovic added this to the 3.18.0 milestone Dec 16, 2024
@acicovic acicovic self-assigned this Dec 16, 2024
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

📝 Walkthrough

Walkthrough

The pull request introduces an upgrade of the Node.js runtime version from 18.12 to 22.12. This change is reflected in both the .nvmrc configuration file and the package.json file's engines section. The update increases the minimum required Node.js version to 22.12.0 and the minimum npm version to 10.9.0, indicating a significant version jump in the project's runtime environment.

Changes

File Change Summary
.nvmrc Updated Node.js version from 18.12 to 22.12
package.json Updated engines section:
- Node.js version requirement changed to >=22.12.0
- npm version requirement changed to >=10.9.0

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant NVM as Node Version Manager
    participant Node as Node.js Runtime

    Dev->>NVM: Specify Node.js version 22.12
    NVM->>Node: Validate and switch runtime
    Node-->>Dev: Confirm runtime version
Loading

The sequence diagram illustrates the process of updating and validating the Node.js runtime version, showing how a developer specifies the new version, which is then managed and validated by the Node Version Manager.

Possibly related PRs

Suggested labels

Component: Dependencies, Changelog: Changed

Suggested reviewers

  • vaurdan

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34007f5 and 8278976.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build
  • GitHub Check: E2E against WordPress latest
  • GitHub Check: build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@acicovic acicovic marked this pull request as ready for review December 16, 2024 13:13
@acicovic acicovic requested a review from a team as a code owner December 16, 2024 13:13
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03a4eef and d1c5ab5.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .nvmrc (1 hunks)
  • package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .nvmrc

package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant