-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional page_type
parameter to ParselyMetadata
class in iOS SDK
#90
Open
MartinAkram
wants to merge
8
commits into
master
Choose a base branch
from
add_page_type_param_to_ParselyMetadata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
077c8bb
Add optional page_type parameter to ParselyMetadata for iOS SDK
MartinAkram 1dbe32a
Update existing tests to account for new page_type param
MartinAkram 560536f
Fix MetatadataTests error
MartinAkram a858ea3
update demo app to test for changes
MartinAkram 7efc706
Add all metadata fields in iOS
MartinAkram 83103cb
Add missed comma
MartinAkram aa5396c
Add new params as vars in ParselyMetadata class
MartinAkram 2503aec
Fix broken tests locally before pushing to Github next time [facepalm…
MartinAkram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, @MartinAkram, my suggestion here was terribly unspecific. Let's drop save_date, custom_metadata, save_date_tmsp, pub_date_tmsp, urls, full_content_word_count, data_source, canonical_hash, canonical_hash64, video_platform, full_content, full_content_sha512, network_id_str, and content_enrichments. Those are all either internal fields that we generate ourselves or they're impractical to send in a pixel like full_content. Sorry for the wasted effort because of my lack of specificity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get more information about expected types here where the code lives for parsing in-px metadata.