Merge pull request #63 from ParclLabs/bug/msg

fix validation error messaging
ParclLabs · Aug 30, 2024 · c057f27 · c057f27
2 parents 7423e49 + 90c8db9
commit c057f27
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+### v1.6.0
+- Bug fix for handling of 422 validation errors.
+
 ### v1.6.0
 - Introduce `turbo_mode` - smart routing for premium api users to reduce latency for bulk data pulls. 
 - Bux fix on output dataframes - inconsistent column order.

diff --git a/parcllabs/__version__.py b/parcllabs/__version__.py
@@ -1 +1 @@
-VERSION = "1.6.0"
+VERSION = "1.6.1"
diff --git a/parcllabs/services/parcllabs_service.py b/parcllabs/services/parcllabs_service.py
@@ -312,7 +312,7 @@ def error_handling(self, response: requests.Response) -> None:
                 error_message += " Visit https://dashboard.parcllabs.com for more information or reach out to [email protected]."
             elif response.status_code == 422:
                 details = error_details.get("detail")
-                error_message = details.get("msg", "validation error")
+                error_message = details[0].get("msg", "validation error")
             elif response.status_code == 429:
                 error_message = error_details.get("error", "Rate Limit Exceeded")
             elif response.status_code == 404:

diff --git a/tests/test_price_feed_service.py b/tests/test_price_feed_service.py
@@ -195,7 +195,7 @@ def test_error_handling_422(self, service):
         response = Mock()
         response.status_code = 422
         response.json.return_value = {
-            "detail": {'msg': 'Invalid input'},
+            "detail": [{'msg': 'Invalid input'}],
         }
         with pytest.raises(RequestException, match="422 Client Error"):
             service.error_handling(response)