-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One vector for regexes and matchers #133
base: master
Are you sure you want to change the base?
One vector for regexes and matchers #133
Conversation
I like where you're gong with this, but I think the modern idiom is to use std::variant and std::visit instead of inheritance: https://www.bfilipek.com/2020/04/variant-virtual-polymorphism.html Can you put together another PR on a different branch using that method and see how feasible it is? And maybe split out the cleanup efforts to a new PR so we can just get things merged. |
I'm not sure we should give up on this. I'd like more time to compare to how the std::variant version came out. |
registeredRegexesAndMatchers
vector