Fix: Economy machinery now uses TGUI input + global bank pin range defines #27913
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
Burzah
reviewed
Jan 9, 2025
Signed-off-by: Burzah <[email protected]>
ParadiseSS13-Bot
added
-Status: Awaiting review
lewcc
reviewed
Jan 10, 2025
|
As per discord discussion, bank pin ranges are now defines in misc_defines and they were put into all appropriate tgui_inputs I could find. |
Toastical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #27888
Puts the account pin ranges in misc_defines.dm and replaces relevant occurences with it.
Economy machinery will now use tgui input. ATM's also use the vendors TGUI input, thus those are fixed as well
Why It's Good For The Game
old menu is very iffy. new menu lets you cancel out and copy paste.
Images of changes
Testing
Loaded in, received pin code within the range.
Checked various machines
Checked all outcomes of vendor transactions
Declaration
Changelog
🆑
fix: Vendors now use TGUI input
/:cl: