-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTBF] Adds a new hallucination, Blind Rushers! #27717
base: master
Are you sure you want to change the base?
[PTBF] Adds a new hallucination, Blind Rushers! #27717
Conversation
…rtura/Tauradise into paratoberfest_blind_stalkers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the way this looks.
Given the way the text is flavored, I think some tweaks to how this sounds would bring the whole package together.
At a glance, maybe one of the hallucination ambiences (I'm here whispered stuff), or maybe shadowdemon/shadownodeambientt.ogg seems like it'd be a good fit. There's a spookoween/ghost_whisper that'd be good too.
As for impacts themselves, something like misc/demon_attack1 maybe?
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
Oooh, I didn't know where to find sounds! (wdym they're in the sound folder? no way.) This would make it way better. Those are a bit long though. Gonna see if they stop once the hallucination is over or not. |
well it seems that something in either 897dd39 or in 77d10d2 caused my hallucination to not spawn the effect correctly at the start but somehow still spawn the two other once it hits the triggers? Looking into it rn EDIT : So it's not 77d10d2 and I highly doubt it's the other so.. I have no clue currently. Debugging has been moved to tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for your problem with spawning three rushers, well. Your code clearly spawns only two. One in on_trigger()
and one in on_second_trigger()
. I am not quite sure how you've managed to spawn the third one before, but the code here clearly doesn't even attempt to spawn it.
EDIT: Code actually does attempt it, I'm just not the sharpest knife in the drawer.
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, something important I forgot to mention:
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
code/modules/hallucinations/effects/blind_rush_hallucination.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, would like another set of eyes!
keep in mind that for some reason only the last two hallucinations appear now |
It is an issue in the underlying manager code and was fixed in #27648, so updating your branch should fix it. |
busy with IRL stuff atm, will try to work on this before next wednesday. |
Co-authored-by: DGamerL <[email protected]> Signed-off-by: Taurtura <[email protected]>
Co-authored-by: DGamerL <[email protected]> Signed-off-by: Taurtura <[email protected]>
why. Why did it do that- Edit : Alright commit reverted. Everything's fine now. I think. |
124ef02
to
22c3914
Compare
Signed-off-by: Luc <[email protected]>
Co-authored-by: DGamerL <[email protected]> Signed-off-by: Taurtura <[email protected]>
What Does This PR Do
This adds a major hallucination that has a very low chance to roll which makes you blind while semi-transparent humanoids rush at you. It also makes you collapse at the end of it and sends spooky message in your chat.
Also add the ability to change the plane of your hallucination.
Why It's Good For The Game
More hallucinations is good.
This turned out a bit worse than I expected, however I often bash myself saying my stuff is bad so.. I guess it's best for others to tell me if it really is.
Images of changes
Unsure if this will work, first time implementing a MP4 in github
2024-12-22.20-13-54.mp4
Testing
I used the hallucination verb to force myself to see it.
also stared at an active SM until I got the hallucination after setting the weight to 100 to make sure it happened naturally
Declaration
Changelog
🆑
add: adds a new hallucination that makes humanoids rush at you while you're blind
/:cl: