Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTBF] Adds a new hallucination, Blind Rushers! #27717

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Taurtura
Copy link
Contributor

What Does This PR Do

This adds a major hallucination that has a very low chance to roll which makes you blind while semi-transparent humanoids rush at you. It also makes you collapse at the end of it and sends spooky message in your chat.
Also add the ability to change the plane of your hallucination.

Why It's Good For The Game

More hallucinations is good.
This turned out a bit worse than I expected, however I often bash myself saying my stuff is bad so.. I guess it's best for others to tell me if it really is.

Images of changes

Unsure if this will work, first time implementing a MP4 in github

2024-12-22.20-13-54.mp4

Testing

I used the hallucination verb to force myself to see it.
also stared at an active SM until I got the hallucination after setting the weight to 100 to make sure it happened naturally


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: adds a new hallucination that makes humanoids rush at you while you're blind
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 22, 2024
Copy link
Contributor

@pwbokie pwbokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the way this looks.

Given the way the text is flavored, I think some tweaks to how this sounds would bring the whole package together.

At a glance, maybe one of the hallucination ambiences (I'm here whispered stuff), or maybe shadowdemon/shadownodeambientt.ogg seems like it'd be a good fit. There's a spookoween/ghost_whisper that'd be good too.

As for impacts themselves, something like misc/demon_attack1 maybe?

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting review This PR is awaiting review from the review team labels Dec 25, 2024
@Taurtura
Copy link
Contributor Author

I really like the way this looks.

Given the way the text is flavored, I think some tweaks to how this sounds would bring the whole package together.

At a glance, maybe one of the hallucination ambiences (I'm here whispered stuff), or maybe shadowdemon/shadownodeambientt.ogg seems like it'd be a good fit. There's a spookoween/ghost_whisper that'd be good too.

As for impacts themselves, something like misc/demon_attack1 maybe?

Oooh, I didn't know where to find sounds! (wdym they're in the sound folder? no way.)

This would make it way better. Those are a bit long though. Gonna see if they stop once the hallucination is over or not.

@Taurtura
Copy link
Contributor Author

Taurtura commented Dec 25, 2024

well it seems that something in either 897dd39 or in 77d10d2 caused my hallucination to not spawn the effect correctly at the start but somehow still spawn the two other once it hits the triggers? Looking into it rn

EDIT : So it's not 77d10d2 and I highly doubt it's the other so.. I have no clue currently. Debugging has been moved to tomorrow.

Copy link
Contributor

@Gatchapod Gatchapod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for your problem with spawning three rushers, well. Your code clearly spawns only two. One in on_trigger() and one in on_second_trigger(). I am not quite sure how you've managed to spawn the third one before, but the code here clearly doesn't even attempt to spawn it.

EDIT: Code actually does attempt it, I'm just not the sharpest knife in the drawer.

Copy link
Contributor

@Gatchapod Gatchapod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, something important I forgot to mention:

Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 26, 2024
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, would like another set of eyes!

@lewcc lewcc requested a review from DGamerL January 3, 2025 21:57
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 3, 2025
@Taurtura
Copy link
Contributor Author

Taurtura commented Jan 4, 2025

keep in mind that for some reason only the last two hallucinations appear now
I have no idea why or how or when that happened.
It's still good to go in but if someone finds out what made it not spawn one at the beginning I'd be very grateful

@Gatchapod
Copy link
Contributor

Gatchapod commented Jan 5, 2025

It is an issue in the underlying manager code and was fixed in #27648, so updating your branch should fix it.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 6, 2025
@Taurtura
Copy link
Contributor Author

Taurtura commented Jan 9, 2025

busy with IRL stuff atm, will try to work on this before next wednesday.

@Taurtura
Copy link
Contributor Author

Taurtura commented Jan 10, 2025

why. Why did it do that-
WHY ARE THE CONFLICTS NOT EVEN RESOLVED-

Edit : Alright commit reverted. Everything's fine now. I think.

@ParadiseSS13-Bot ParadiseSS13-Bot added Map Edit This PR will modify a map Configuration Change This PR changes the game configuration files. Please run via the host. Sprites This PR modifies the game sprites Sound This PR modifies the game sound TGUI This PR modifies TGUI, will conflict labels Jan 10, 2025
@Taurtura Taurtura force-pushed the paratoberfest_blind_stalkers branch from 124ef02 to 22c3914 Compare January 10, 2025 18:08
@DGamerL DGamerL removed request for a team and AffectedArc07 January 10, 2025 18:13
@DGamerL DGamerL removed Map Edit This PR will modify a map Sound This PR modifies the game sound Sprites This PR modifies the game sprites Configuration Change This PR changes the game configuration files. Please run via the host. TGUI This PR modifies TGUI, will conflict labels Jan 10, 2025
@lewcc lewcc requested a review from DGamerL January 10, 2025 21:07
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants