Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTBF] Wavy Vision #27674

Merged
merged 9 commits into from
Jan 10, 2025
Merged

[PTBF] Wavy Vision #27674

merged 9 commits into from
Jan 10, 2025
+61 −1

Conversation

BiancaWilkson
Copy link
Contributor

What Does This PR Do

Adds a hallucination that adds a random amount of wave filters to the player's screen. The strength of each individual instance of the hallucination will be random.

Why It's Good For The Game

More hallucinations are cool, and having everything look like it's slightly moving is pretty accurate to tripping IRL.

Images of changes

2024-12-18.13-02-10.mp4

Testing

See above

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: A hallucination that makes the screen look wavy.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team labels Dec 18, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 26, 2024
Drsmail
Drsmail approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Drsmail Drsmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Realy clean code, i like it!

code/modules/hallucinations/effects/waves_hallucination.dm Show resolved Hide resolved
lewcc
lewcc reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it needs to do, and looks good doing it. LGTM

code/modules/hallucinations/effects/waves_hallucination.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 6, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 8, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 9, 2025
@lewcc lewcc added the Feature This PR is a new addition to the game label Jan 9, 2025
lewcc
lewcc previously requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hallucination needs to be added to the hallucination list, otherwise it'll never show.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Jan 10, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 10, 2025
@lewcc lewcc dismissed their stale review January 10, 2025 20:34

addressed

lewcc
lewcc approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@Burzah Burzah added this pull request to the merge queue Jan 10, 2025
Merged via the queue into ParadiseSS13:master with commit 699788c Jan 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drsmail Drsmail Drsmail approved these changes

@Burzah Burzah Burzah approved these changes

@lewcc lewcc lewcc approved these changes

@FunnyMan3595 FunnyMan3595 FunnyMan3595 approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting review This PR is awaiting review from the review team Feature This PR is a new addition to the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BiancaWilkson @FunnyMan3595 @Drsmail @lewcc @Burzah @ParadiseSS13-Bot