Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack Chain Migration: /turf #27530

Merged

Conversation

warriorstar-orion
Copy link
Contributor

@warriorstar-orion warriorstar-orion commented Dec 3, 2024

What Does This PR Do

This PR migrates /turf and its subtypes to the new attack chain.

It also adds signal_procs and comp_lookup to the list of variables that are not copied when using /area/proc/copy_contents_to, which shouldn't affect anything except the holodeck and the thunderdome. Copying these vars over to newly created turfs meant that the signal handlers were pointing at the original turfs instead of the new turfs.

Why It's Good For The Game

Important foundational type to move over, unblocks other contributors.

Testing

  • Ensure that holofloors cannot be interacted with tools: unscrewed, crowbarred, or welded
  • Ensure that holofloors cannot be attacked with a welder
  • Verify replacing tiles with crowbar/tile hand combination
  • Verify digging asteroid floor with shovel
  • Verify picking up ore by using ore bag on asteroid floor
  • Verify building lattice over chasm
  • Verify building plating on chasm lattice
  • Verify shoveling grass
  • Verify building heatproof lattice over lava
  • Verify using floor tile on lava under lattice
  • Verify scooping plasma with reagent container (message is incorrect but not my fault)
  • Verify constructing lattice with screwdriver, then plating, for chasms
  • Verify replacing bulb for light floors (removed in Remove unused 'broken light' light floor state #27548)
  • Verify attacking plasma floor with welder
  • Verify attacking plasma floor with hot item
  • Verify bananium floor honking on attacks, and removal with crowbar
  • Verify uranium floor radiating on attacks, and removal with crowbar
  • Verify crowbar attacks destroy metal foam floors
  • Verify wood wall cover removal with melee
  • Verify reinforced wall deconstruction
  • Verify reinforced wall metal sheet patch-up
  • Verify placement of rods in space for lattice, and then for catwalk
  • Verify placement of floor tiles on space lattice, and requiring lattice
  • Verify cable coil placement on plating

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC god willing

@Burzah Burzah added the Attack Chain Migration Refactoring of legacy attack chain items label Dec 3, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting review This PR is awaiting review from the review team label Dec 3, 2024
@warriorstar-orion warriorstar-orion marked this pull request as ready for review December 5, 2024 06:27
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Dec 6, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Active This PR is currently testmerged on production and removed Testmerge Active This PR is currently testmerged on production labels Dec 12, 2024
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just "while you're here" changes. I don't see anything else that stands out

code/game/turfs/simulated/minerals.dm Outdated Show resolved Hide resolved
code/game/turfs/simulated/minerals.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Dec 21, 2024
@warriorstar-orion
Copy link
Contributor Author

@lewcc i put in a few tests to mirror the testing checklist in the PR: mounting air alarm frames on a wall, using rods on plating to reinforce the floor, and using an ore bag on an asteroid floor in order to automatically pick up the ore on it. If you see other things on the checklist you'd like concrete tests for, let me know.

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Dec 23, 2024
@matttheficus
Copy link
Contributor

Adjacent turf clicks appear to be broken for the Mining Resonator and Rapid Pipe Dispenser. Confirmed by Xenni during round 43194.

@matttheficus
Copy link
Contributor

Soap cannot clean floors as well adjacent to the player.

@warriorstar-orion
Copy link
Contributor Author

The issues discovered in round 43194 have been caught and fixed, with new tests added for them.

@ColKev1 ColKev1 mentioned this pull request Jan 3, 2025
1 task
code/tests/_game_test_puppeteer.dm Outdated Show resolved Hide resolved
code/tests/_game_test_puppeteer.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 7, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Jan 10, 2025
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comfortable with this PR given all the testing done for it.
Lewcs good to me.

@Burzah Burzah added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 10, 2025
@Burzah Burzah added this pull request to the merge queue Jan 10, 2025
Merged via the queue into ParadiseSS13:master with commit 3db86c8 Jan 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Attack Chain Migration Refactoring of legacy attack chain items Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants