-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attack Chain Migration: /turf #27530
Attack Chain Migration: /turf #27530
Conversation
…orion/Paradise into attack-chain-migration/turf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly just "while you're here" changes. I don't see anything else that stands out
Co-authored-by: Luc <[email protected]> Signed-off-by: warriorstar-orion <[email protected]>
…orion/Paradise into attack-chain-migration/turf
Co-authored-by: Luc <[email protected]> Signed-off-by: warriorstar-orion <[email protected]>
@lewcc i put in a few tests to mirror the testing checklist in the PR: mounting air alarm frames on a wall, using rods on plating to reinforce the floor, and using an ore bag on an asteroid floor in order to automatically pick up the ore on it. If you see other things on the checklist you'd like concrete tests for, let me know. |
…orion/Paradise into attack-chain-migration/turf
Adjacent turf clicks appear to be broken for the Mining Resonator and Rapid Pipe Dispenser. Confirmed by Xenni during round 43194. |
Soap cannot clean floors as well adjacent to the player. |
The issues discovered in round 43194 have been caught and fixed, with new tests added for them. |
…orion/Paradise into attack-chain-migration/turf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comfortable with this PR given all the testing done for it.
Lewcs good to me.
What Does This PR Do
This PR migrates
/turf
and its subtypes to the new attack chain.It also adds
signal_procs
andcomp_lookup
to the list of variables that are not copied when using/area/proc/copy_contents_to
, which shouldn't affect anything except the holodeck and the thunderdome. Copying these vars over to newly created turfs meant that the signal handlers were pointing at the original turfs instead of the new turfs.Why It's Good For The Game
Important foundational type to move over, unblocks other contributors.
Testing
Declaration
Changelog
NPFC god willing