-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move const q
under Constants
#558
base: master
Are you sure you want to change the base?
Move const q
under Constants
#558
Conversation
This PR moves the definition of the constant `q` under "Constants". See [556](PainterQubits#556) I also changed the comment on the line defining `q` from "`e` means 2.718..." to "avoid naming conflict with `e`", as I feel the original phrasing could be confused with the `e` in the line that means "times 10 to the power of..."
You only moved the definition of |
Nice catch @sostock. However, eV is not a constant, but a unit. So I will move it to under the "constants" section, right? |
Once you are working on the constants: are you aware of #545 ? |
not at all |
IMO, you can also move it into the constants section (right below |
That is not an argument to move |
That’s fine too, although I like that the units are defined immediately after the constants on which they are based. |
There is sone appeal, but I personally look up the variables for constants all the time, and love having them all in one place. So that has more weight to me, as I frequently make use of it. |
This PR moves the definition of the constant
q
under "Constants". See #556.I also changed the comment on the line defining
q
from "e
means 2.718..." to "avoid naming conflict withe
", as I feel the original phrasing could be confused with thee
in the line that means "times 10 to the power of..."