Merge pull request #58 from simonbyrne/sb/isapprox

fix isapprox units
PainterQubits · Mar 6, 2017 · ead2d96 · ead2d96
2 parents b714b69 + 4409f44
commit ead2d96
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Unitful.jl b/src/Unitful.jl
@@ -787,7 +787,7 @@ isless(x::Number, y::Quantity) = _isless(promote(x,y)...)
 end
 
 isapprox{T,D,U}(x::Quantity{T,D,U}, y::Quantity{T,D,U}; atol=zero(Quantity{real(T),D,U}), kwargs...) =
-    isapprox(x.val, y.val; atol=atol.val, kwargs...)
+    isapprox(x.val, y.val; atol=uconvert(unit(y), atol).val, kwargs...)
 isapprox(x::Quantity, y::Quantity; kwargs...) = isapprox(uconvert(unit(y), x).val, y.val; kwargs...)
 isapprox(x::Quantity, y::Number; kwargs...) = isapprox(uconvert(NoUnits, x), y; kwargs...)
 isapprox(x::Number, y::Quantity; kwargs...) = isapprox(y,x; kwargs...)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -397,6 +397,8 @@ end
 
         @test isapprox(1.0u"m", 1.1u"m"; atol=0.2u"m")
         @test !isapprox(1.0u"m", 1.1u"m"; atol=0.05u"m")
+        @test isapprox(1.0u"m", 1.1u"m"; atol=200u"mm")
+        @test !isapprox(1.0u"m", 1.1u"m"; atol=50u"mm")
         @test isapprox(1.0u"m", 1.1u"m"; rtol=0.2)
         @test !isapprox(1.0u"m", 1.1u"m"; rtol=0.05)
     end