Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CN docs: api/paddle/optimizer/Optimizer_cn.html #6157

Conversation

linzeyang
Copy link
Contributor

Inspired by: 飞桨快乐开源活动全新升级🔥
Issue from: https://shimo.im/sheets/2Us6FhlaVAgxfHys/ytCqF (No. 31)

英文文档对parameters的描述支持tuple,中文没有,需要补充。

@paddle-bot
Copy link

paddle-bot bot commented Sep 3, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6157.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2023

CLA assistant check
All committers have signed the CLA.

@linzeyang linzeyang marked this pull request as ready for review September 3, 2023 17:42
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunzhongkai588
Copy link
Collaborator

sunzhongkai588 commented Sep 4, 2023

@linzeyang 如果对文档活动感兴趣,可以进群参与更多活动~

@linzeyang
Copy link
Contributor Author

LGTM

@sunzhongkai588 谢谢您的审核,请问Docs-NEW这个失败要怎么处理呢?

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 谢谢您的审核,请问Docs-NEW这个失败要怎么处理呢?

等 CI rerun 通过即可

@sunzhongkai588 sunzhongkai588 merged commit 19f8c39 into PaddlePaddle:develop Sep 4, 2023
1 check passed
@linzeyang
Copy link
Contributor Author

@sunzhongkai588 谢谢您的审核,请问Docs-NEW这个失败要怎么处理呢?

等 CI rerun 通过即可

谢谢,现在已经通过了 :)

@linzeyang linzeyang deleted the fix/api/paddle/optimizer/Optimizer_cn.html branch September 4, 2023 06:33
@Ligoml Ligoml added the HappyOpenSource 快乐开源活动issue与PR label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants