[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base #58185

enkilee · 2023-10-18T04:47:48Z

PR types

Others

PR changes

Others

Description

[CodeStyle] Ruff upgrade and addition of paddle.base check #57367
Task 10 B017

paddle-bot · 2023-10-18T04:47:53Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

luotao1 · 2023-10-20T06:40:22Z

@gouzil 可以review了

gouzil · 2023-10-22T01:51:05Z

test/dygraph_to_static/test_assert.py

@@ -42,7 +42,7 @@ class TestAssertVariable(Dy2StTestBase):
    def _run(self, func, x, with_exception, to_static):
        paddle.jit.enable_to_static(to_static)
        if with_exception:
-            with self.assertRaises(BaseException):
+            with self.assertRaises(BaseException):  # noqa: B017


Suggested change

with self.assertRaises(BaseException): # noqa: B017

with self.assertRaises(AssertionError):

这里从语义上来看，就是应该捕获各种异常的，noqa 是可以的，除非重构代码，不是传入 True/False 而是传入异常类型

gouzil · 2023-10-22T01:51:06Z

test/legacy_test/test_cuda_max_memory_allocated.py

@@ -61,10 +61,10 @@ def test_max_memory_allocated_exception(self):
                "gpu1",
            ]
            for device in wrong_device:
-                with self.assertRaises(BaseException):
+                with self.assertRaises(BaseException):  # noqa: B017


Suggested change

with self.assertRaises(BaseException): # noqa: B017

with self.assertRaises((ValueError, AssertionError)):

这四个 memory 的为什么是 ValueError, AssertionError 呢？这是能全部捕获的么？

gouzil · 2023-10-22T01:51:07Z

test/legacy_test/test_cuda_max_memory_reserved.py

@@ -61,10 +61,10 @@ def test_max_memory_reserved_exception(self):
                "gpu1",
            ]
            for device in wrong_device:
-                with self.assertRaises(BaseException):
+                with self.assertRaises(BaseException):  # noqa: B017


Suggested change

with self.assertRaises(BaseException): # noqa: B017

with self.assertRaises((ValueError, AssertionError)):

gouzil · 2023-10-22T01:51:10Z

test/legacy_test/test_cuda_memory_allocated.py

@@ -46,10 +46,10 @@ def test_memory_allocated_exception(self):
                "gpu1",
            ]
            for device in wrong_device:
-                with self.assertRaises(BaseException):
+                with self.assertRaises(BaseException):  # noqa: B017


Suggested change

with self.assertRaises(BaseException): # noqa: B017

with self.assertRaises((ValueError, AssertionError)):

gouzil · 2023-10-22T01:51:13Z

test/legacy_test/test_cuda_memory_reserved.py

@@ -46,10 +46,10 @@ def test_memory_reserved_exception(self):
                "gpu1",
            ]
            for device in wrong_device:
-                with self.assertRaises(BaseException):
+                with self.assertRaises(BaseException):  # noqa: B017


Suggested change

with self.assertRaises(BaseException): # noqa: B017

with self.assertRaises((ValueError, AssertionError)):

test/legacy_test/test_tensordot.py

gouzil

LGTM, @SigureMo

SigureMo

LGTMeow 🐾

…dlePaddle#58185)

fix B017

e6f2c59

paddle-bot bot added the contributor External developers label Oct 18, 2023

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 18, 2023

luotao1 assigned luotao1 and SigureMo Oct 18, 2023

enkilee added 6 commits October 18, 2023 06:49

fix

023921e

fix

bbcf3c7

fix

17b9275

fix

e071188

Merge branch 'develop' into codestyle-task3-Ruff-B017

899ca97

fix

2090f9b

gouzil reviewed Oct 22, 2023

View reviewed changes

test/legacy_test/test_tensordot.py Outdated Show resolved Hide resolved

gouzil mentioned this pull request Oct 22, 2023

[CodeStyle] Ruff upgrade and addition of paddle.base check #57367

Closed

fix

e37064d

gouzil approved these changes Oct 23, 2023

View reviewed changes

SigureMo approved these changes Oct 23, 2023

View reviewed changes

SigureMo merged commit c460816 into PaddlePaddle:develop Oct 23, 2023
28 checks passed

hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base (Pad…

3dd85f7

…dlePaddle#58185)

jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base (Pad…

e6d5249

…dlePaddle#58185)

danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base (Pad…

6cc57ca

…dlePaddle#58185)

enkilee deleted the codestyle-task3-Ruff-B017 branch December 19, 2023 05:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base #58185

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base #58185

enkilee commented Oct 18, 2023

paddle-bot bot commented Oct 18, 2023

luotao1 commented Oct 20, 2023

gouzil Oct 22, 2023

SigureMo Oct 22, 2023

enkilee Oct 23, 2023

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

SigureMo Oct 22, 2023

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

gouzil left a comment

SigureMo left a comment

	with self.assertRaises(BaseException): # noqa: B017
	with self.assertRaises(AssertionError):

	with self.assertRaises(BaseException): # noqa: B017
	with self.assertRaises((ValueError, AssertionError)):

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base #58185

[CodeStyle][task 10] enable ruff B017 rule in python/paddle/base #58185

Conversation

enkilee commented Oct 18, 2023

PR types

PR changes

Description

paddle-bot bot commented Oct 18, 2023

luotao1 commented Oct 20, 2023

gouzil Oct 22, 2023

Choose a reason for hiding this comment

SigureMo Oct 22, 2023

Choose a reason for hiding this comment

enkilee Oct 23, 2023

Choose a reason for hiding this comment

gouzil Oct 22, 2023 • edited by SigureMo Loading

Choose a reason for hiding this comment

SigureMo Oct 22, 2023

Choose a reason for hiding this comment

gouzil Oct 22, 2023 • edited by SigureMo Loading

Choose a reason for hiding this comment

gouzil Oct 22, 2023 • edited by SigureMo Loading

Choose a reason for hiding this comment

gouzil Oct 22, 2023 • edited by SigureMo Loading

Choose a reason for hiding this comment

gouzil left a comment

Choose a reason for hiding this comment

SigureMo left a comment

Choose a reason for hiding this comment

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

gouzil Oct 22, 2023 •

edited by SigureMo

Loading

gouzil Oct 22, 2023 •

edited by SigureMo

Loading