Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][task 9] enable Ruff UP030 rule in python/paddle/base #58162

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[CodeStyle][task 9] enable Ruff UP030 rule in python/paddle/base #58162

merged 1 commit into from
Oct 18, 2023

Conversation

Kaedeharai
Copy link
Contributor

PR types

others

PR changes

others

Description

这个我不知道为什么它检查出来只有两处

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 17, 2023
@gouzil
Copy link
Member

gouzil commented Oct 17, 2023

这个我不知道为什么它检查出来只有两处

因为UP032 跟它有部分重复, 这是没问题的

@gouzil
Copy link
Member

gouzil commented Oct 17, 2023

LGTM, @SigureMo

@gouzil gouzil mentioned this pull request Oct 17, 2023
Closed
SigureMo
SigureMo approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 18, 2023
@luotao1 luotao1 merged commit 55cc5ed into PaddlePaddle:develop Oct 18, 2023
28 checks passed
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
@Kaedeharai @wentaoyu
[CodeStyle][task 9] enable Ruff UP030 rule in python/paddle/base (Pad…
83eaaa2 
…dlePaddle#58162)
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
@Kaedeharai @jiahy0825
[CodeStyle][task 9] enable Ruff UP030 rule in python/paddle/base (Pad…
1914a08 
…dlePaddle#58162)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@Kaedeharai
[CodeStyle][task 9] enable Ruff UP030 rule in python/paddle/base (Pad…
1e63b0c 
…dlePaddle#58162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kaedeharai @gouzil @SigureMo @luotao1