Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][task 27] Enable Ruff B009 rule in python/paddle/base #57709

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

linzeyang
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

This PR comes after the idea in #57367.

The purpose is to activate Ruff's B009 check.

Ruff version: 0.0.290

What I've done:

Uncomment "B009", line in pyproject.toml
Take advantage of Ruff to identify and automatically fix relevant violations.
Make sure no B009 violation is found after the fix.
Make sure all local pre-commit hooks pass/skip

@gouzil

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gouzil
Copy link
Member

gouzil commented Sep 25, 2023

LGTM,@SigureMo

SigureMo
SigureMo previously approved these changes Sep 25, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 26, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 26, 2023

需要解决下冲突

@linzeyang
Copy link
Contributor Author

需要解决下冲突

冲突已解决 😸

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff version: 0.0.290

才发现用的是高版本,注意之后版本需要和我们的 .pre-commit-config.yaml 完全对应,否则不确定是否会漏掉 / 多检测出来什么问题

LGTMeow 🐾

@SigureMo SigureMo merged commit bc52f6c into PaddlePaddle:develop Sep 27, 2023
@linzeyang linzeyang deleted the CodeStyle/task-27-Ruff-B009 branch September 27, 2023 01:37
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants