Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][task 26] Enable Ruff B004 rule in python/paddle/base #57708

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

linzeyang
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

This PR comes after the idea in #57367.

The purpose is to activate Ruff's B004 check.

Ruff version: 0.0.290

What I've done:

Uncomment "B004", line in pyproject.toml
Take advantage of Ruff to identify and automatically fix relevant violations.
Make sure no B004 violation is found after the fix.
Make sure all local pre-commit hooks pass/skip

@gouzil

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 25, 2023
@linzeyang linzeyang changed the title [CodeStyle][task 26] - Enable Ruff B004 rule in python/paddle/base [CodeStyle][task 26] Enable Ruff B004 rule in python/paddle/base Sep 25, 2023
@gouzil
Copy link
Member

gouzil commented Sep 25, 2023

LGTM, @SigureMo

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 26, 2023
@luotao1 luotao1 merged commit 4a02ef1 into PaddlePaddle:develop Sep 26, 2023
@linzeyang linzeyang deleted the CodeStyle/task-26-Ruff-B004 branch September 26, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants