Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][task 35-37] enable Flake8 E712 E266 E724 rule in python/paddle/base #57590

Closed
wants to merge 1 commit into from

Conversation

entired
Copy link
Contributor

@entired entired commented Sep 21, 2023

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 21, 2023
@entired entired changed the title delete E712,E266,E714 [CodeStyle][task 35-37] enable Flake8 E712 E266 E724 rule in python/paddle/base Sep 21, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 21, 2023
@gouzil
Copy link
Member

gouzil commented Sep 22, 2023

  1. 需要先解决一下冲突
  2. 打开检查并重新扫描错误码
  3. 需要将.flake8文件中的ignore提交上来,这样ci才能正常检查
per-file-ignores =
    # These files need tabs for testing.
    test/dygraph_to_static/test_error.py:E101,W191
    # temp ignore base directory
-    python/paddle/base/*:
-        E713,
-        E712,
-        E266,

@entired entired closed this by deleting the head repository Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants