Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Saved Payment Methods #67

Merged
merged 7 commits into from
Nov 14, 2024
Merged

feat: Saved Payment Methods #67

merged 7 commits into from
Nov 14, 2024

Conversation

davidgrayston-paddle
Copy link
Contributor

Added

  • Support for saved payment methods, see related changelog
    • Client.payment_methods.list
    • Client.payment_methods.get
    • Client.payment_methods.delete
    • Client.customers.create_auth_token

@davidgrayston-paddle davidgrayston-paddle self-assigned this Nov 12, 2024
@davidgrayston-paddle davidgrayston-paddle changed the title Feat/payment methods feat: Saved Payment Methods Nov 12, 2024
davidgrayston-paddle
davidgrayston-paddle commented Nov 12, 2024
View reviewed changes
paddle_billing/Notifications/Entities/Entity.py

event_entity = event_type.split(".")[0] or ""

return event_entity.lower().title()
return event_entity.lower().title().replace("_", "")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replacement is needed to convert payment_method → PaymentMethod

paddle_billing/Notifications/Entities/PaymentMethodDeleted.py
origin: SavedPaymentMethodOrigin
saved_at: datetime
updated_at: datetime
deletion_reason: SavedPaymentMethodDeletionReason
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaymentMethodDeleted entity has additional deletion_reason property

@davidgrayston-paddle davidgrayston-paddle marked this pull request as ready for review November 13, 2024 15:16
@davidgrayston-paddle davidgrayston-paddle requested a review from a team as a code owner November 13, 2024 15:16
vifer
vifer previously approved these changes Nov 14, 2024
View reviewed changes
@davidgrayston-paddle davidgrayston-paddle requested review from vifer and a team November 14, 2024 12:45
@davidgrayston-paddle davidgrayston-paddle requested review from vifer and a team November 14, 2024 14:46
@davidgrayston-paddle davidgrayston-paddle merged commit acc1b11 into main Nov 14, 2024
11 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the feat/payment-methods branch November 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifer vifer vifer approved these changes

Assignees

@davidgrayston-paddle davidgrayston-paddle

Labels
norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgrayston-paddle @vifer