fix: Subscription IDs can be omitted when creating customer portal se…

…ssions
PaddleHQ · Dec 3, 2024 · ae40e4b · ae40e4b
1 parent 38aff5b
commit ae40e4b
Show file tree

Hide file tree

Showing 7 changed files with 45 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 Check our main [developer changelog](https://developer.paddle.com/?utm_source=dx&utm_medium=paddle-python-sdk) for information about changes to the Paddle Billing platform, the Paddle API, and other developer tools.
 
+## 1.2.1 - 2024-12-04
+
+### Fixed
+
+- Subscription IDs can be omitted when creating customer portal sessions
+
 ## 1.2.0 - 2024-12-03
 
 ### Added

diff --git a/paddle_billing/Client.py b/paddle_billing/Client.py
@@ -204,7 +204,7 @@ def build_request_session(self) -> Session:
                 "Authorization": f"Bearer {self.__api_key}",
                 "Content-Type": "application/json",
                 "Paddle-Version": str(self.use_api_version),
-                "User-Agent": "PaddleSDK/python 1.2.0",
+                "User-Agent": "PaddleSDK/python 1.2.1",
             }
         )
 

diff --git a/paddle_billing/Resources/CustomerPortalSessions/Operations/CreateCustomerPortalSession.py b/paddle_billing/Resources/CustomerPortalSessions/Operations/CreateCustomerPortalSession.py
@@ -1,8 +1,9 @@
 from dataclasses import dataclass
 
 from paddle_billing.Operation import Operation
+from paddle_billing.Undefined import Undefined
 
 
 @dataclass
 class CreateCustomerPortalSession(Operation):
-    subscription_ids: list[str] = (None,)
+    subscription_ids: list[str] | Undefined = Undefined()
diff --git a/setup.py b/setup.py
@@ -2,7 +2,7 @@
 
 
 setup(
-    version="1.2.0",
+    version="1.2.1",
     author="Paddle and contributors",
     author_email="[email protected]",
     description="Paddle's Python SDK for Paddle Billing",

diff --git a/tests/Functional/Resources/CustomerPortalSessions/_fixtures/request/create_empty.json b/tests/Functional/Resources/CustomerPortalSessions/_fixtures/request/create_empty.json
@@ -0,0 +1,3 @@
+{
+    "subscription_ids": []
+}
diff --git a/tests/Functional/Resources/CustomerPortalSessions/_fixtures/response/full_entity_empty.json b/tests/Functional/Resources/CustomerPortalSessions/_fixtures/response/full_entity_empty.json
@@ -0,0 +1,16 @@
+{
+  "data": {
+    "id": "cpls_01h4ge9r64c22exjsx0fy8b48b",
+    "customer_id": "ctm_01gysfvfy7vqhpzkq8rjmrq7an",
+    "urls": {
+      "general": {
+        "overview": "https://customer-portal.paddle.com/cpl_01j7zbyqs3vah3aafp4jf62qaw?action=overview&token=pga_eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJjdG1fMDFncm5uNHp0YTVhMW1mMDJqanplN3kyeXMiLCJuYW1lIjoiSm9obiBEb2UiLCJpYXQiOjE3Mjc2NzkyMzh9._oO12IejzdKmyKTwb7BLjmiILkx4_cSyGjXraOBUI_g"
+      },
+      "subscriptions": []
+    },
+    "created_at": "2024-10-25T06:53:58Z"
+  },
+  "meta": {
+    "request_id": "fa176777-4bca-49ec-aa1e-f53885333cb7"
+  }
+}
diff --git a/tests/Functional/Resources/CustomerPortalSessions/test_CustomerPortalSessionsClient.py b/tests/Functional/Resources/CustomerPortalSessions/test_CustomerPortalSessionsClient.py
@@ -32,10 +32,26 @@ class TestAddressesClient:
                 ReadsFixtures.read_raw_json_fixture("response/full_entity_multiple"),
                 "/customers/ctm_01gysfvfy7vqhpzkq8rjmrq7an/portal-sessions",
             ),
+            (
+                "ctm_01gysfvfy7vqhpzkq8rjmrq7an",
+                CreateCustomerPortalSession([]),
+                ReadsFixtures.read_raw_json_fixture("request/create_empty"),
+                ReadsFixtures.read_raw_json_fixture("response/full_entity_empty"),
+                "/customers/ctm_01gysfvfy7vqhpzkq8rjmrq7an/portal-sessions",
+            ),
+            (
+                "ctm_01gysfvfy7vqhpzkq8rjmrq7an",
+                CreateCustomerPortalSession(),
+                "{}",
+                ReadsFixtures.read_raw_json_fixture("response/full_entity_empty"),
+                "/customers/ctm_01gysfvfy7vqhpzkq8rjmrq7an/portal-sessions",
+            ),
         ],
         ids=[
             "Create portal session with single subscription ID",
             "Create portal session with multiple subscription IDs",
+            "Create portal session with empty subscription IDs",
+            "Create portal session with ommitted subscription IDs",
         ],
     )
     def test_create_uses_expected_payload(