Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simulator API #84

Merged
merged 10 commits into from
Oct 17, 2024
Merged

feat: Simulator API #84

merged 10 commits into from
Oct 17, 2024

Conversation

vifer
Copy link
Contributor

@vifer vifer commented Oct 2, 2024

Added

@vifer vifer self-assigned this Oct 2, 2024
vifer
vifer commented Oct 2, 2024
View reviewed changes
src/Entities/Simulation.php Outdated Show resolved Hide resolved
@vifer vifer added the norelease label Oct 2, 2024
@vifer vifer changed the title Feat/simulator api feat:simulator api Oct 3, 2024
@vifer vifer changed the title feat:simulator api feat: Simulator api Oct 3, 2024
@vifer vifer changed the title feat: Simulator api feat: Simulator API Oct 3, 2024
davidgrayston-paddle
davidgrayston-paddle previously approved these changes Oct 4, 2024
View reviewed changes
src/Entities/Shared/JSONObject.php Outdated Show resolved Hide resolved
src/Entities/Simulation.php Outdated Show resolved Hide resolved
src/Entities/SimulationRun.php Outdated Show resolved Hide resolved
mikeymike
mikeymike reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@mikeymike mikeymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty solid 💪

src/Entities/SimulationRun.php Outdated Show resolved Hide resolved
src/Entities/SimulationRunEvent.php Outdated Show resolved Hide resolved
src/Entities/SimulationType.php Outdated Show resolved Hide resolved
src/Resources/Simulations/Operations/UpdateSimulation.php Outdated Show resolved Hide resolved
src/Entities/Shared/JSONObject.php Outdated Show resolved Hide resolved
@davidgrayston-paddle davidgrayston-paddle mentioned this pull request Oct 8, 2024
Merged
@vifer vifer force-pushed the feat/simulator-api branch from 9705eee to dc2e660 Compare October 8, 2024 13:12
@vifer vifer marked this pull request as ready for review October 17, 2024 08:23
@vifer vifer requested a review from a team as a code owner October 17, 2024 08:23
davidgrayston-paddle
davidgrayston-paddle reviewed Oct 17, 2024
View reviewed changes
examples/simulations.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vifer added simulation example to demonstrate payload creation

davidgrayston-paddle
davidgrayston-paddle previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@davidgrayston-paddle davidgrayston-paddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Added example to demonstrate simulation create/update

@davidgrayston-paddle davidgrayston-paddle merged commit d370f6c into main Oct 17, 2024
4 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the feat/simulator-api branch October 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeymike mikeymike mikeymike left review comments

@davidgrayston-paddle davidgrayston-paddle davidgrayston-paddle approved these changes

Assignees

@vifer vifer

Labels
norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vifer @mikeymike @davidgrayston-paddle