Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateDiscount and UpdateDiscount Ops are missing Custom Data #57 #58

Merged
merged 4 commits into from
Aug 21, 2024
Merged

CreateDiscount and UpdateDiscount Ops are missing Custom Data #57 #58

merged 4 commits into from
Aug 21, 2024

Conversation

dutypro
Copy link
Contributor

@dutypro dutypro commented Aug 20, 2024

Fixes bug #57

@dutypro dutypro requested a review from a team as a code owner August 20, 2024 14:44
vifer
vifer requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@vifer vifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dutypro thank you so much for raising this PR to fix the CreateDiscount and UpdateDiscount operations, I've just left small suggestions regarding the imports order.

We will bump the version after this PR gets merged.

src/Entities/Discount.php Outdated Show resolved Hide resolved
src/Resources/Discounts/Operations/CreateDiscount.php Outdated Show resolved Hide resolved
src/Resources/Discounts/Operations/UpdateDiscount.php Outdated Show resolved Hide resolved
dutypro and others added 3 commits August 20, 2024 17:11
@dutypro dutypro requested a review from vifer August 20, 2024 16:12
vifer
vifer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@vifer vifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@vifer vifer merged commit acb176b into PaddleHQ:main Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifer vifer vifer approved these changes

Assignees
No one assigned
Labels
norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dutypro @vifer @vijayasingam-paddle @sjking85