fix!: Privatise entities and improve typing #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeymike
force-pushed
the
fix/entity-internal-constructors
branch
2 times, most recently
from
8b021ba to
25754fe
Compare
- Most entities are private constructors - Request shared classes are public - Removed `@internal` to prevent IDE warnings - Made Events use their respective Event class - These are correctly made private while Event is `@internal` - Made enums final where they previously were not BREAKING CHANGE: Allowing extension of enums was not intended this is now removed, any reliance on this will break BREAKING CHANGE: Most entities are now private constructors, using these was not intended API, reliance on this will break
mikeymike
force-pushed
the
fix/entity-internal-constructors
branch
from
25754fe to
085c275
Compare
vifer
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@internalto prevent IDE warnings@internalBREAKING CHANGE: Allowing extension of enums was not intended this is now removed, any reliance on this will break
BREAKING CHANGE: Most entities are now private constructors, using these was not intended API, reliance on this will break