fix!: Align subscription price with Price entity #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Subscription Item uses main Price Entity - Subscription notification supports new Price fields BREAKING CHANGE: The class type for a subscription item price property has changed to the main Price entity. Any reliance on the old type will need to be refactored accordingly.
mikeymike
commented
Feb 16, 2024
| @@ -36,7 +36,7 @@ protected function __construct( | |||
| public CatalogType|null $type, | |||
| public TimePeriod|null $billingCycle, | |||
| public TimePeriod|null $trialPeriod, | |||
| public TaxMode|null $taxMode, | |||
| public TaxMode $taxMode, | |||
There was a problem hiding this comment.
Not sure why this was nullable. Doesn't look like it should have been.
mikeymike
commented
Feb 16, 2024
| @@ -36,7 +36,7 @@ protected function __construct( | |||
| public CatalogType|null $type, | |||
| public TimePeriod|null $billingCycle, | |||
| public TimePeriod|null $trialPeriod, | |||
| public TaxMode|null $taxMode, | |||
| public TaxMode $taxMode, | |||
There was a problem hiding this comment.
Here also, doesn't look like it should ever have been nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The class type for a subscription item price property has changed to the main Price entity. Any reliance on the old type will need to be refactored accordingly.