Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Map subscription transaction adjustments #28

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

mikeymike
Copy link
Contributor

@mikeymike mikeymike commented Feb 6, 2024

Adjustments within next transaction and the immediate transaction of subscriptions were not mapped.

Adjustment items on Adjustments entity was not mapped.

Transactions had a specific implementation of Adjustments that isn't required, replaced with core Adjustment entity.

There was some stray Subscription classes I couldn't see usages of, they're removed now.

@mikeymike mikeymike force-pushed the fix/subscription-adjustments branch from d3f79fb to 6e8c59f Compare February 7, 2024 12:32
@mikeymike mikeymike force-pushed the fix/subscription-adjustments branch from 6e8c59f to 7551ef9 Compare February 7, 2024 12:34
- CreateAdjustment now has a write specific AdjustmentItem
- Adjustment entities are shared between Adjustments and Subscriptions
  - AdjustmentProration
  - AdjustmentType
  - AdjustmentTimePeriod

BREAKING CHANGE: To create an Adjustment you must now use `\Paddle\SDK\Resources\Adjustments\Operations\Create\AdjustmentItem`
@mikeymike mikeymike marked this pull request as ready for review February 8, 2024 12:20
@mikeymike mikeymike requested a review from a team February 8, 2024 12:20
@mikeymike mikeymike merged commit 349485e into main Feb 8, 2024
3 checks passed
@mikeymike mikeymike deleted the fix/subscription-adjustments branch February 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants