fix!: Make implementors of Entity internal #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeymike
force-pushed
the
fix/privatise-entity-constructors
branch
from
266d23a to
c605cdc
Compare
mikeymike
force-pushed
the
fix/privatise-entity-constructors
branch
4 times, most recently
from
b68463a to
58b7def
Compare
Implementors of \Paddle\SDK\Entities\Entity should not be used directly. To prevent this the constructors are now protected, and the static factory should be used instead conforming to the shape of the API. Each isntance is also documented as @internal now BREAKING CHANGE: Makes core Entity constructors private.
mikeymike
force-pushed
the
fix/privatise-entity-constructors
branch
from
58b7def to
2c74478
Compare
vifer
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementors of
\Paddle\SDK\Entities\Entityshould not be used directly. To prevent this the constructors are now private, and the static factory should be used instead conforming to the shape of the API.A PHPCS rule has been added to automate this and prevent future breakages.
BREAKING CHANGE: Makes core Entity constructors private.