fix(Simulations): Update types for list and update for generics

PaddleHQ · Oct 8, 2024 · ec0ef62 · ec0ef62
1 parent be3ae08
commit ec0ef62
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/resources/simulations/index.ts b/src/resources/simulations/index.ts
@@ -26,9 +26,7 @@ const SimulationPaths = {
 } as const;
 
 export class SimulationsResource extends BaseResource {
-  public list<T extends IEventName | SimulationScenarioType>(
-    queryParams?: ListSimulationQueryParameters,
-  ): SimulationCollection<T> {
+  public list(queryParams?: ListSimulationQueryParameters): SimulationCollection<IEventName | SimulationScenarioType> {
     const queryParameters = new QueryParameters(queryParams);
     return new SimulationCollection(this.client, SimulationPaths.list + queryParameters.toQueryString());
   }
@@ -62,14 +60,14 @@ export class SimulationsResource extends BaseResource {
 
   public async update<T extends IEventName | SimulationScenarioType>(
     simulationId: string,
-    updateSimulation: UpdateSimulationRequestBody,
+    updateSimulation: UpdateSimulationRequestBody<T>,
   ): Promise<Simulation<T>> {
     const urlWithPathParams = new PathParameters(SimulationPaths.update, {
       simulation_id: simulationId,
     }).deriveUrl();
 
     const response = await this.client.patch<
-      UpdateSimulationRequestBody,
+      UpdateSimulationRequestBody<T>,
       Response<ISimulationResponse<T>> | ErrorResponse
     >(urlWithPathParams, updateSimulation);
 

diff --git a/src/resources/simulations/operations/update-simulation-request-body.ts b/src/resources/simulations/operations/update-simulation-request-body.ts
@@ -5,12 +5,12 @@
  */
 
 import type { SimulationScenarioType, Status } from '../../../enums';
-import type { IEventName } from '../../../notifications';
+import type { EventMap, IEventName } from '../../../notifications';
 
-export interface UpdateSimulationRequestBody {
+export interface UpdateSimulationRequestBody<T extends IEventName | SimulationScenarioType> {
   notificationSettingId?: string;
   name?: string;
   status?: Status;
-  type?: IEventName | SimulationScenarioType;
-  payload?: any;
+  type?: T;
+  payload?: (T extends IEventName ? EventMap[T] : null) | null;
 }