Skip to content

Commit

Permalink
v4.4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
avalore committed Nov 11, 2022
1 parent 0245644 commit 78887ec
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 2 deletions.
Binary file modified Paddle.framework/Versions/A/Paddle
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
2 changes: 1 addition & 1 deletion Paddle.framework/Versions/A/Resources/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<key>DTXcodeBuild</key>
<string>14A5294e</string>
<key>LSMinimumSystemVersion</key>
<string>10.14.6</string>
<string>10.13</string>
<key>NSHumanReadableCopyright</key>
<string>Copyright © 2017 Paddle. All rights reserved.</string>
<key>PADMajorMinorVersion</key>
Expand Down
2 changes: 1 addition & 1 deletion PaddleV4.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ SOFTWARE.
'Louis Harwood' => '[email protected]'
}

s.platform = :osx, '10.10'
s.platform = :osx, '10.13'
s.source = { :http => "https://github.com/PaddleHQ/Mac-Framework-V4/archive/v4.4.0.zip" }
s.vendored_framework = 'Mac-Framework-V4-4.4.0/Paddle.framework'
s.requires_arc = false
Expand Down

2 comments on commit 78887ec

@someziggyman
Copy link

@someziggyman someziggyman commented on 78887ec Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, thanks a lot for fixing this with OS versions and it seems to be all fine now. however, got a quick question and possibly improvement.

Let's say, we have the following scenario:
user had his license key already "utilised with error -122". here's entered his e-mail +license key, but he's out of activations. Now he wants to activate it on a newer Mac and gets the error message.
Now I have to catch this error and make it simple for him to reset the oldest activation or just reset all together. I'm catching -(void)paddleDidError:(NSError *)error and - (BOOL)willShowPaddleAlert:(nonnull PADAlert *)alert, but in this particular scenario PADAlert object with its .product.licenseCode is NULL, NSError from the first message has also no trace for the license code or e-mail from the initial activation attempt dialogue. So now I have to create a separate window with a textfield and ask him to enter the license code again (which he already did a moment ago before getting an error)... am I missing something? or maybe in the next framework update you could just pass license code (and just in case e-mail as well) either to NSerror.userinfo object of -(void)paddleDidError:(NSError *)error method. Or add properties for PADAlert in method - (BOOL)willShowPaddleAlert:(nonnull PADAlert *)alert

If any testing is needed, I'll be glad to help. Thank you for keeping PaddleSDK flexible!

@avalore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @someziggyman

Now Activation Reclaim is out we'll be adding further to this functionality and expanding the ways in which you can use it.
This was a first pass to get the core feature released. Subsequent releases will see this being added to.

We'll take your suggestion on board!

Please sign in to comment.