Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new parameter for GNSS system selection #69

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

jbeyerstedt
Copy link
Contributor

A new PX4 parameter is needed to configure the set of used GNSS systems. This PR changes the GPSHelper::configure() interface method used by the GPS drivers to include another parameter for the configuration (with the same data format, as the PX4 parameter).
Additionally the actual feature of setting the GNSS configuration was implemented for uBlox devices.

See #68 for details.

@jbeyerstedt
Copy link
Contributor Author

I decided to not add a default value to the new parameter of that method, because it isn't needed any more when the corresponding change in PX4 was merged. But therefore the changes in this repository and in PX4 depend on each other. Let me know, if this is an issue.
My proposal for the procedure would be to merge this first and do the submodule update in PX4 as part of the PX4/PX4-Autopilot#16505 pull request.

@jbeyerstedt jbeyerstedt marked this pull request as draft January 7, 2021 11:47
@jbeyerstedt jbeyerstedt marked this pull request as ready for review January 7, 2021 13:25
@jbeyerstedt
Copy link
Contributor Author

And could somebody please test this with a uBlox generation 9 receiver (or some other one, which is using at least protocol version 27/ the config-valset interface)? I only have a Pixhawk 4 GPS, which is using the configureDevicePreV27() code.

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll test this on a newer module.

src/ashtech.cpp Outdated Show resolved Hide resolved
src/gps_helper.h Show resolved Hide resolved
src/ubx.cpp Outdated Show resolved Hide resolved
src/ubx.cpp Outdated Show resolved Hide resolved
Functionality not implemented yet, see issue PX4#68 for details
@jbeyerstedt jbeyerstedt force-pushed the pr-gnss-selection branch 2 times, most recently from 548e7f9 to fab7647 Compare January 11, 2021 17:34
src/ubx.cpp Outdated Show resolved Hide resolved
@bkueng
Copy link
Member

bkueng commented Jan 12, 2021

I tested with an F9P, but it does not work, I always get a NACK: setting UBX_CFG_KEY_SIGNAL_SBAS_ENA consistently fails, either enabling or disabling. The same result with u-center, so I think the code is correct, and I don't know why it fails. We could apply SBAS separately so at least the other settings apply.

I also noticed a bug: https://github.com/PX4/PX4-GPSDrivers/blob/master/src/ubx.cpp#L1294 should use ubx_sat_svId.

@jbeyerstedt
Copy link
Contributor Author

The SBAS settings have been moved to the bottom of the section, committing the other changes beforehand. Additionally I explicitly set the used signal for SBAS now (even tough it should be set to that value by default). Maybe this works better.

The other bug is addressed im #70.

@bkueng bkueng merged commit 52535dc into PX4:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants