-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new parameter for GNSS system selection #69
Conversation
I decided to not add a default value to the new parameter of that method, because it isn't needed any more when the corresponding change in PX4 was merged. But therefore the changes in this repository and in PX4 depend on each other. Let me know, if this is an issue. |
0091365
to
c742176
Compare
And could somebody please test this with a uBlox generation 9 receiver (or some other one, which is using at least protocol version 27/ the config-valset interface)? I only have a Pixhawk 4 GPS, which is using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll test this on a newer module.
Functionality not implemented yet, see issue PX4#68 for details
548e7f9
to
fab7647
Compare
I tested with an F9P, but it does not work, I always get a NACK: setting I also noticed a bug: https://github.com/PX4/PX4-GPSDrivers/blob/master/src/ubx.cpp#L1294 should use |
fab7647
to
3919a5f
Compare
The SBAS settings have been moved to the bottom of the section, committing the other changes beforehand. Additionally I explicitly set the used signal for SBAS now (even tough it should be set to that value by default). Maybe this works better. The other bug is addressed im #70. |
A new PX4 parameter is needed to configure the set of used GNSS systems. This PR changes the
GPSHelper::configure()
interface method used by the GPS drivers to include another parameter for the configuration (with the same data format, as the PX4 parameter).Additionally the actual feature of setting the GNSS configuration was implemented for uBlox devices.
See #68 for details.