Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtol_att_control: ack transition commands #8264

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

julianoes
Copy link
Contributor

Previously transition commands were not acked at all which meant that a
mavlink consumer such as a ground station would not get feedback if the
command arrived.

This solution is not optimal because it does not take into account if
the transition actually happened but at least it is feedback that the
command has arrived at the destination.

This solves an issue raised in mavlink/MAVSDK#150.

Tested in SITL using

make posix gazebo_standard_vtol

and for DroneCore:

make && build/default/integration_tests_runner --gtest_filter="SitlTest.ActionSimpleTransition"

Previously transition commands were not acked at all which meant that a
mavlink consumer such as a ground station would not get feedback if the
command arrived.

This solution is not optimal because it does not take into account if
the transition actually happened but at least it is feedback that the
command has arrived at the destination.
@dagar
Copy link
Member

dagar commented Nov 9, 2017

Thanks, I was actually about to add this for QGC. mavlink/qgroundcontrol#5827

@julianoes
Copy link
Contributor Author

@dagar do we need to check stack usage on NuttX?

@dagar
Copy link
Member

dagar commented Nov 10, 2017

Worst case it will dip into the 300 byte warning level and briefly be annoying.

@julianoes julianoes merged commit 585b038 into master Nov 13, 2017
@julianoes julianoes deleted the vtol-transition-ack branch November 13, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants