Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More version bumps #1259

Merged
merged 4 commits into from
Dec 26, 2024
Merged

More version bumps #1259

merged 4 commits into from
Dec 26, 2024

Conversation

fabiocicerchia
Copy link
Collaborator

@fabiocicerchia fabiocicerchia commented Dec 20, 2024

composer lock changes:

Lock file operations: 0 installs, 36 updates, 0 removals
  - Upgrading doctrine/deprecations (1.1.3 => 1.1.4)
  - Upgrading friendsofphp/php-cs-fixer (v3.64.0 => v3.65.0)
  - Upgrading jean85/pretty-package-versions (2.0.6 => 2.1.0)
  - Upgrading knplabs/packagist-api (v2.1.0 => v2.1.1)
  - Upgrading monolog/monolog (3.8.0 => 3.8.1)
  - Upgrading phpdocumentor/reflection-docblock (5.6.0 => 5.6.1)
  - Upgrading phpspec/prophecy (v1.19.0 => v1.20.0)
  - Upgrading phpspec/prophecy-phpunit (v2.2.0 => v2.3.0)
  - Upgrading phpstan/phpstan (1.12.10 => 1.12.13)
  - Upgrading phpstan/phpstan-phpunit (1.4.1 => 1.4.2)
  - Upgrading phpunit/phpunit (9.6.21 => 9.6.22)
  - Upgrading predis/predis (v2.2.2 => v2.3.0)
  - Upgrading roave/security-advisories (dev-latest 9f1d9b2 => dev-latest abbccc9)
  - Upgrading sentry/sentry-symfony (5.0.1 => 5.1.0)
  - Upgrading snc/redis-bundle (4.7.2 => 4.8.0)
  - Upgrading symfony/cache (v7.1.7 => v7.1.9)
  - Upgrading symfony/cache-contracts (v3.5.0 => v3.5.1)
  - Upgrading symfony/dependency-injection (v7.1.8 => v7.1.9)
  - Upgrading symfony/deprecation-contracts (v3.5.0 => v3.5.1)
  - Upgrading symfony/dom-crawler (v7.1.6 => v7.1.9)
  - Upgrading symfony/dotenv (v7.1.6 => v7.1.9)
  - Upgrading symfony/event-dispatcher-contracts (v3.5.0 => v3.5.1)
  - Upgrading symfony/http-client (v7.1.8 => v7.1.9)
  - Upgrading symfony/http-client-contracts (v3.5.0 => v3.5.2)
  - Upgrading symfony/http-foundation (v7.1.8 => v7.1.9)
  - Upgrading symfony/http-kernel (v7.1.8 => v7.1.9)
  - Upgrading symfony/options-resolver (v7.1.6 => v7.1.9)
  - Upgrading symfony/phpunit-bridge (v7.2.0-RC1 => v7.2.0)
  - Upgrading symfony/property-info (v7.1.8 => v7.1.9)
  - Upgrading symfony/routing (v7.1.6 => v7.1.9)
  - Upgrading symfony/security-core (v7.1.6 => v7.1.9)
  - Upgrading symfony/service-contracts (v3.5.0 => v3.5.1)
  - Upgrading symfony/translation-contracts (v2.5.3 => v2.5.4)
  - Upgrading symfony/twig-bridge (v7.1.8 => v7.1.9)
  - Upgrading symfony/web-profiler-bundle (v7.1.7 => v7.1.9)
  - Upgrading twig/twig (v3.14.2 => v3.17.1)

@fabiocicerchia fabiocicerchia marked this pull request as draft December 20, 2024 20:48
Copy link
Member

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't make much sense to update Symfony 7.1
We should go for 7.2 (which, of course, requires a change in composer.json too)

Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JellyBellyDev
Copy link
Member

I think it doesn't make much sense to update Symfony 7.1 We should go for 7.2 (which, of course, requires a change in composer.json too)

I think it makes sense for now, as a first deploy after a while I'd rather not add any more entropy.
I would switch to sf72 at a later time in a different PR and in a different deployment.

@fabiocicerchia fabiocicerchia marked this pull request as ready for review December 26, 2024 18:42
@fabiocicerchia fabiocicerchia merged commit b9846fb into master Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants