Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable certs on dev #1210

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Enable certs on dev #1210

merged 7 commits into from
Oct 9, 2024

Conversation

fabiocicerchia
Copy link
Collaborator

No description provided.

@fabiocicerchia fabiocicerchia marked this pull request as draft September 7, 2024 07:24
@fabiocicerchia fabiocicerchia marked this pull request as ready for review September 7, 2024 19:35
Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!!!
I try this version in local and https://poser.local:8002 works, but http://poser.local:8001 do a 301 to https://poser.pugx.org

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After last two commits i have the following error: ERR_CONNECTION_REFUSED

And I see these files changes:

jellybelly at mbp-jellybelly in ~/github_com/pugx/badge-poser (enable-certs-on-dev)
$ git st
Sul branch enable-certs-on-dev
Il tuo branch è aggiornato rispetto a 'origin/enable-certs-on-dev'.

Modifiche non nell'area di staging per il commit:
  (usa "git add <file>..." per aggiornare gli elementi di cui sarà eseguito il commit)
  (usa "git restore <file>..." per scartare le modifiche nella directory di lavoro)
	modificato:             sys/nginx/certs/ca-crt.pem
	modificato:             sys/nginx/certs/ca-crt.srl
	modificato:             sys/nginx/certs/ca-key.pem
	modificato:             sys/nginx/certs/server.csr
	modificato:             sys/nginx/certs/server.key
	modificato:             sys/nginx/certs/server.pem

It's normal? Maybe we manage these files with gitignore?

@fabiocicerchia
Copy link
Collaborator Author

I've rebased, and it works on my machine :trollface:

regarding those files, I've ignored them.

@JellyBellyDev
Copy link
Member

Now I have ERR_CONNECTION_REFUSED with https://poser.local:8002 and http://poser.local:8001.

My steps to reproduce it:

git reset --hard origin/enable-certs-on-dev
git pull origin enable-certs-on-dev
make stop
make run

@fabiocicerchia
Copy link
Collaborator Author

@JellyBellyDev I've pruned buildx and system, removed all local images and running containers, then cleared my local branches and pulled from origin.

then did make stop and make run. Then when accessing https://poser.local:8002/ I get only Error code: SEC_ERROR_UNKNOWN_ISSUER but I can easily bypass it by accepting the TLS exception.

@JellyBellyDev
Copy link
Member

Ok now works also for me!
But if you execute this?

$ curl -I poser.local:8001
HTTP/1.1 302 Moved Temporarily
Server: openresty
Date: Tue, 24 Sep 2024 13:49:24 GMT
Content-Type: text/html
Content-Length: 142
Connection: keep-alive
Location: https://poser.local

?
Sure that is correct this redirect?

Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JellyBellyDev JellyBellyDev merged commit 111c7d8 into master Oct 9, 2024
5 checks passed
@JellyBellyDev JellyBellyDev deleted the enable-certs-on-dev branch October 9, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants