-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add git info to build #4804
Conversation
Not finished; needs some cleaning + need to resolve how the tests & book should work
for more information, see https://pre-commit.ci
This requires bumping the MSRV from 1.70.0 to 1.73.0. Would that be OK with everyone? @eitsupi ? Debian is now on 1.79.0. 1.73.0 is 10 months old. |
Bumping MSRV is fine. |
Thanks for working on this. |
edit: I think probably I misunderstood, given you also said "I think this feature is great" — can I ask what you mean by " Do you know of any projects that would be helpful?"? TY! |
I switched to using I would have thought it would be a bit slower, but actually the time to execute
|
Sorry for failing to ask the right question. I just wanted to know if there are other packages out there with similar functionality. |
Ah, sorry, I understand now! Lots of python projects do this — so running For rust — I browsed dependents of vergen, which has 20K repos and 200 packages. GitHub doesn't organize by popularity, but one random example is https://github.com/sxyazi/yazi/blob/d2ebadb6314e3d124a173b6683399e8d33acb429/yazi-cli/build.rs#L8 |
Not finished; needs some cleaning + need to resolve how the tests & book should workReady to mergeWould replace #4546 (hope that's OK!)