Shield Activity #416
Open
Shield Activity #416
+214
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
diff --git a/package.json b/package.json
index 547b11a..4b044ca 100644
--- a/package.json
+++ b/package.json
@@ -89,9 +89,9 @@
"jquery": "^3.6.3",
"pinia": "^2.1.7",
"pivx-promos": "^0.2.0",
- "pivx-shield": "^1.1.6",
- "pivx-shield-rust": "^1.1.6",
- "pivx-shield-rust-multicore": "^1.1.10",
+ "pivx-shield": "^1.2.0-0",
+ "pivx-shield-rust": "^1.2.0-0",
+ "pivx-shield-rust-multicore": "^1.2.0-1",
"qr-scanner": "^1.4.2",
"qrcode-generator": "^1.4.4",
"vue": "^3.3.4",I published a beta version with pivx-shield#81, apply this patch and |
Duddino
requested changes
Oct 7, 2024
| * @param {number} amount - The net amount of transparent PIVs in a transaction | ||
| * @param {number} shieldAmount - The net amount of shielded PIVs in a transaction | ||
| */ | ||
| function txSelfMap(amount, shieldAmount) { |
…the Shield manager
panleone
force-pushed
the
shield_activity_final
branch
from
278267a
to
4516976
Compare
|
Reviews applied:
|
panleone
force-pushed
the
shield_activity_final
branch
from
1747d76
to
7f2ad19
Compare
JSKitty
added
Review Reward: 20 PIV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Implements shield activity, i.e. shield transactions regarding the wallet are decrypted and loaded in the dashboard activity.
3 new transactions types have been added:
Transactions received and sent to external wallets are marked as before, with the addition of shield addresses:
I suggest to review the PR commit by commit, is easier than looking at the overall diff. Also to test the PR you have to manually build and use the following version of the pivx-shield library: PR 81.
Testing
To test this PR, it's suggested to attempt these user flows, or variations of these: