Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample collection #26
Sample collection #26
Changes from 6 commits
73d07f0
d572671
886513a
f44f904
5890ab4
cc8af81
8cdd4f6
f4beda2
f3d90c8
c51569f
d2461d8
a1c235e
8d71d2f
f50eb28
81c0d95
d337cf0
08771e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines add the DNI and Passport to the patient header (and make them editable via the header). Not sure if that's what you want, but I wanted to add it in as a example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple changes here, see below... instead of a "type of identifier" column and a "identifier" column, this renders a separate column for DNI and Passport (feel free to adjust the labels as you see fit).
I believe this isn't exactly what you wanted, but it seemed good to do this as a start as we work through potential changes to the Core Apps module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a nice workaround. But i think in the future we might add more document types, therefore having more columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, yeah, makes sense @MiguelAHPpih see my updated comments on the coreapps pull request about moving forward with supporting multiple identifiers per column:
openmrs/openmrs-module-coreapps#414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this, until we get the coreapps function. Mergin it!