Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added the function getOTPUrl to get the otp:// url from the secret #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

her-finn
Copy link

@her-finn her-finn commented Oct 2, 2020

since i don't want to send the screts to google, i created a function that outputs the otp: // url and then creates the barcode itself

The function works like the getQRCodeGoogleUrl function, but without the parameter $params.

@MarkMaldaba
Copy link

Good thinking.

I would also update getQRCodeGoogleUrl() to call this new function, rather than duplicating the functionality.

@her-finn
Copy link
Author

her-finn commented Apr 4, 2021

I dont think so because the function is named getQRCodeGoogleUrl(). People who want a fast copy and paste solution are thinking that some data ist send to google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants